feature: add Cache expiry settings #17
Conversation
| @@ -29,6 +29,8 @@ class EmbedExtensionFactory { | |||
| 'ExternalContentFileExtensionWhitelist' => [ 'md' ], | |||
| 'wgExternalContentEnableEmbedFunction' => true, | |||
| 'wgExternalContentEnableBitbucketFunction' => true, | |||
| 'ExternalContentDefaultExpiry' => 86400, | |||
There was a problem hiding this comment.
should these be prefixed with 'wg'?
There was a problem hiding this comment.
With wg
I made it consistent in #18
| } elseif ( is_int( self::getCacheExpiry() ) && !self::hasReducedExpiry() ) { | ||
| $parser->getOutput()->updateCacheExpiry( self::getCacheExpiry() ); | ||
| } | ||
| } |
There was a problem hiding this comment.
The if $parser is not needed. You can tell by the function signature you always get one.
That said, this code should be elsewhere. onParserFirstCallInit gets called always, even if there is no embedded content on a page.
There was a problem hiding this comment.
See the BitbucketFunction and EmbedFunction classes at https://github.com/ProfessionalWiki/ExternalContent/tree/master/src/EntryPoints for the code that handles calls to these parser functions.
There was a problem hiding this comment.
So I "don't repeat myself", should the code be added to the EmbedExtensionFactory, and then referenced from the entrypoints?
Jeroen, this is my first attempt.
I know I can't call updateCacheExpiry() on a null parser object (see error) but I'm not sure what to do... I was going to check hooks and see if it needs to be implemented in a different hook function besides onParserFirstCallInit()
Error from line 23 of /var/www/html/extensions/ExternalContent/src/EntryPoints/MediaWikiHooks.php: Call to a member function updateCacheExpiry() on null
Can you look at my efforts and give me any feedback?
Aside: I would normally do this in a feature branch, but had some trouble getting VSCode in a container to work with GitHub, and the terminal was constrained (no prompts) so I had to do some docker file copies back to my host machine and then still ended up pushing to 'master' in my forked repo :-(